Skip to content

Reset set filter after changing group filter#3688

Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom
mttsch:bugfix/rector-set-after-group-change
May 5, 2026
Merged

Reset set filter after changing group filter#3688
TomasVotruba merged 1 commit intorectorphp:mainfrom
mttsch:bugfix/rector-set-after-group-change

Conversation

@mttsch
Copy link
Copy Markdown
Contributor

@mttsch mttsch commented May 5, 2026

Fix #3686

Comment on lines +67 to +70
public function updatedActiveRectorSetGroup(): void
{
$this->rectorSet = null;
}
Copy link
Copy Markdown
Member

@samsonasik samsonasik May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this new method called? something magic by Component ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a livewire hook that is automatically called, see last code example in section https://livewire.laravel.com/docs/4.x/lifecycle-hooks#update.

@TomasVotruba TomasVotruba merged commit 1d239a9 into rectorphp:main May 5, 2026
8 checks passed
@TomasVotruba
Copy link
Copy Markdown
Member

Awesome, thanks 🙏

@mttsch mttsch deleted the bugfix/rector-set-after-group-change branch May 6, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Find rules: Incorrect behavior for selected set after changing group

3 participants